Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run CI on all PR branches #282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

run CI on all PR branches #282

wants to merge 2 commits into from

Conversation

andrewkolos
Copy link
Contributor

This is a follow-up to #280 (comment). In summary, we only run CI checks on PRs against the main branch. However, in cases where an older major version of a package needs to be patched, it doesn't make sense to PR against main. CI won't run for these PRs, but it probably should.

This updates our GitHub CI configs to run checks against PRs against any branch.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Jun 25, 2024
@github-actions GitHub Actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:unified_analytics 6.1.2 ready to publish unified_analytics-v6.1.2
package:cli_config 0.2.0 already published at pub.dev
package:extension_discovery 2.0.1-wip WIP (no publish necessary)
package:graphs 2.3.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@andrewkolos andrewkolos marked this pull request as ready for review June 25, 2024 22:29
devoncarew
devoncarew reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! lgtm modulo the change to the publishing workflow file.

.github/workflows/publish.yaml Outdated Show resolved Hide resolved
@andrewkolos
Copy link
Contributor Author

FYI: I've created a release for unified_analytics-v6.1.2 since it looks like that never got made after #277 merged. I did this as I didn't want this PR merging to trigger a release from CI.

christopherfujino
christopherfujino approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
type-infra A repository infrastructure change or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewkolos @devoncarew @christopherfujino